use genesis.json for ArbOSInit feature flags#176
Open
Tristan-Wilson wants to merge 1 commit intomasterfrom
Open
use genesis.json for ArbOSInit feature flags#176Tristan-Wilson wants to merge 1 commit intomasterfrom
Tristan-Wilson wants to merge 1 commit intomasterfrom
Conversation
The init.transaction-filtering-enabled config key was added as a temporary integration shim but never merged to nitro master in favor of passing ArbOSInit flags through genesis.json. Switch the testnode to generate an l2_genesis.json containing the chain config as serializedChainConfig plus the arbOSInit flags, and pass it to all L2 nodes via --init.genesis-json-file.
| } | ||
| } | ||
|
|
||
| if (argv.txfiltering) { |
Contributor
There was a problem hiding this comment.
Any issue with generating genesis.json for all cases?
| } | ||
|
|
||
| let l3Config = JSON.parse(baseConfJSON) | ||
| delete l3Config["init"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The init.transaction-filtering-enabled config key was added as a temporary integration shim but never merged to nitro master in favor of passing ArbOSInit flags through genesis.json. Switch the testnode to generate an l2_genesis.json containing the chain config as serializedChainConfig plus the arbOSInit flags, and pass it to all L2 nodes via --init.genesis-json-file.
Testing done
For testing, I ran the same smoke test as in #175
The
--devbuild is no longer needed, you can just specify the latest nitro rc egFixes NIT-4507