Skip to content

fix: add withdrawal integration test and clear pre-existing lint debt #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douglance merged 2 commits into from
Apr 16, 2026
Merged

fix: add withdrawal integration test and clear pre-existing lint debt #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e36aba
feat: add L2-to-L1 / L3-to-L2 ETH withdrawal integration test
douglance Apr 16, 2026
4219b54
chore: clear pre-existing Biome lint errors
douglance Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/action/run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ writeEnv("INTEGRATION_TEST_NITRO_CONTRACTS_BRANCH", state.contractsVersion);

const networkConfigPaths = (process.env["INPUT_NETWORK_CONFIG_PATH"] || "")
.split(",")
.map(p => p.trim())
.map((p) => p.trim())
.filter(Boolean);
for (const dest of networkConfigPaths) {
mkdirSync(dirname(dest), { recursive: true });
Expand Down
58 changes: 34 additions & 24 deletions src/commands/clean.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,38 @@ const PROJECT_ROOT = resolve(import.meta.dirname, "../..");
const CONFIG_DIR = resolve(PROJECT_ROOT, "config");
const COMPOSE_FILE = resolve(PROJECT_ROOT, "docker/docker-compose.yaml");

function stopAllServices(): void {
console.log("[clean] Stopping Docker...");
composeDown({ composeFile: COMPOSE_FILE, projectName: "arbitrum-testnode" });
exec("docker", ["compose", "-f", COMPOSE_FILE, "-p", "arbitrum-testnode", "down", "-v"]);

console.log("[clean] Killing Anvil...");
exec("pkill", ["-f", "anvil.*--port.*8545"]);
exec("pkill", ["-f", "testnode-l1-heartbeat"]);
}

function removeConfigDirPreservingSnapshots(): void {
for (const entry of readdirSync(CONFIG_DIR)) {
if (entry === SNAPSHOTS_DIRNAME) {
continue;
}
rmSync(join(CONFIG_DIR, entry), { recursive: true, force: true });
}
}

function cleanConfigDir(purgeSnapshots: boolean): void {
if (!existsSync(CONFIG_DIR)) {
return;
}
if (purgeSnapshots) {
console.log("[clean] Removing config directory...");
rmSync(CONFIG_DIR, { recursive: true, force: true });
return;
}
console.log("[clean] Removing runtime data and preserving snapshots...");
removeConfigDirPreservingSnapshots();
}

export const cleanCli = Cli.create("clean", {
description: "Stop and remove all testnode data",
options: z.object({
Expand All @@ -20,30 +52,8 @@ export const cleanCli = Cli.create("clean", {
}),
run(c) {
stopCurrentRun(CONFIG_DIR);

console.log("[clean] Stopping Docker...");
composeDown({ composeFile: COMPOSE_FILE, projectName: "arbitrum-testnode" });
exec("docker", ["compose", "-f", COMPOSE_FILE, "-p", "arbitrum-testnode", "down", "-v"]);

console.log("[clean] Killing Anvil...");
exec("pkill", ["-f", "anvil.*--port.*8545"]);
exec("pkill", ["-f", "testnode-l1-heartbeat"]);

if (existsSync(CONFIG_DIR)) {
if (c.options.purgeSnapshots) {
console.log("[clean] Removing config directory...");
rmSync(CONFIG_DIR, { recursive: true, force: true });
} else {
console.log("[clean] Removing runtime data and preserving snapshots...");
for (const entry of readdirSync(CONFIG_DIR)) {
if (entry === SNAPSHOTS_DIRNAME) {
continue;
}
rmSync(join(CONFIG_DIR, entry), { recursive: true, force: true });
}
}
}

stopAllServices();
cleanConfigDir(c.options.purgeSnapshots ?? false);
console.log("[clean] Done.");
return { success: true };
},
Expand Down
Loading
Loading