Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
package com.octopus.openfeature.provider;

import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.Test;

import java.io.InputStream;
import java.util.List;
import java.util.Map;

import static org.assertj.core.api.Assertions.assertThat;

class FeatureToggleEvaluationDeserializationTests {

private final ObjectMapper objectMapper = new ObjectMapper();

private InputStream resource(String name) {
return getClass().getResourceAsStream(name);
}

@Test
void shouldDeserializeEnabledToggle() throws Exception {
FeatureToggleEvaluation result = objectMapper.readValue(
resource("toggle-enabled-no-segments.json"), FeatureToggleEvaluation.class);

assertThat(result.getName()).isEqualTo("My Feature");
assertThat(result.getSlug()).isEqualTo("my-feature");
assertThat(result.isEnabled()).isTrue();
assertThat(result.getSegments()).isEmpty();
}

@Test
void shouldDeserializeDisabledToggle() throws Exception {
FeatureToggleEvaluation result = objectMapper.readValue(
resource("toggle-disabled.json"), FeatureToggleEvaluation.class);

assertThat(result.isEnabled()).isFalse();
}

@Test
void shouldDeserializeToggleWithMissingSegmentsField() throws Exception {
FeatureToggleEvaluation result = objectMapper.readValue(
resource("toggle-missing-segments.json"), FeatureToggleEvaluation.class);

assertThat(result.getSegments()).isNotNull().isEmpty();
}

@Test
void shouldDeserializeToggleWithSegments() throws Exception {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently fails. I haven't worked out if it is a problem with the test or the client code yet.

Copy link
Author

@liamhughes liamhughes Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now think it is a problem with the client code.

OctoToggle returns segments like this:

[
  {
    "key": "license-type",
    "value": "free"
  },
  {
    "key": "country",
    "value": "au"
  }
]

The client is expecting segments like this:

[
  {
    "license-type": "free"
  },
  {
    "country": "au"
  }
]

FeatureToggleEvaluation result = objectMapper.readValue(
resource("toggle-with-segments.json"), FeatureToggleEvaluation.class);

assertThat(result.getSegments()).hasSize(2);
assertThat(result.getSegments()).contains(
Map.entry("license-type", "free"),
Map.entry("country", "au")
);
}

@Test
void shouldDeserializeListOfToggles() throws Exception {
List<FeatureToggleEvaluation> result = objectMapper.readValue(
resource("toggle-list.json"), new TypeReference<List<FeatureToggleEvaluation>>() {});

assertThat(result).hasSize(2);
assertThat(result.get(0).getSlug()).isEqualTo("feature-a");
assertThat(result.get(0).isEnabled()).isTrue();
assertThat(result.get(1).getSlug()).isEqualTo("feature-b");
assertThat(result.get(1).isEnabled()).isFalse();
}

@Test
void shouldIgnoreExtraneousProperties() throws Exception {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails.

FeatureToggleEvaluation result = objectMapper.readValue(
resource("toggle-with-extraneous-properties.json"), FeatureToggleEvaluation.class);

assertThat(result.getName()).isEqualTo("My Feature");
assertThat(result.getSlug()).isEqualTo("my-feature");
assertThat(result.isEnabled()).isTrue();
assertThat(result.getSegments()).isEmpty();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "My Feature",
"slug": "my-feature",
"isEnabled": false,
"segments": null
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "My Feature",
"slug": "my-feature",
"isEnabled": true,
"segments": null
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[
{
"name": "Feature A",
"slug": "feature-a",
"isEnabled": true,
"segments": null
},
{
"name": "Feature B",
"slug": "feature-b",
"isEnabled": false,
"segments": null
}
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"name": "My Feature",
"slug": "my-feature",
"isEnabled": true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"name": "My Feature",
"slug": "my-feature",
"isEnabled": true,
"segments": [
{
"key": "license-type",
"value": "free"
},
{
"key": "country",
"value": "au"
}
]
}
Loading