Skip to content

Update the Build Url #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slewis74 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update the Build Url #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f195dd
Update the build Url to use `index` rather than `results`, as the for…
slewis74 Apr 8, 2022
cfd81fe
Bump the minor version and update the README to explain how the versi…
slewis74 Apr 8, 2022
4bd005f
Update the expected test output
slewis74 Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
branches: [ main ]

env:
OCTOPUS_VERSION: 5.0.${{ github.run_number }}
OCTOPUS_VERSION: 5.1.${{ github.run_number }}

jobs:
build:
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ It's highly recommended to set up two Virtual Machines running Windows Server. T

To install locally, build and package the application as per the instructions above. Then install the extension by uploading it. Instructions to do this are available in Microsoft's [TFS/ADO docs](https://docs.microsoft.com/en-us/vsts/marketplace/get-tfs-extensions?view=tfs-2018#install-extensions-for-disconnected-tfs).

### Local

The SemVer major.minor for the package is currently controlled by the /.github/workflows/build.yml file. Update this file as part of your PR if making breaking/additive changes.

#### Additional tips

* TFS/ADO is accessible on port 8080 by default (this can be changed if desired) at something like the following: `http://<server name/ip>:8080/tfs/`
Expand Down
2 changes: 1 addition & 1 deletion source/tasks/BuildInformation/BuildInformationV5/buildInformation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ describe("Build Information", () => {
expect(buildInformationPayload).toBe(`{
"BuildEnvironment": "Azure DevOps",
"BuildNumber": "1",
"BuildUrl": "${octopusUrl}/test/_build/results?buildId=1",
"BuildUrl": "${octopusUrl}/test/_build/index?buildId=1",
"Branch": "refs/heads/master",
"VcsType": "Git",
"VcsRoot": "",
Expand Down
2 changes: 1 addition & 1 deletion source/tasks/BuildInformation/BuildInformationV5/buildInformation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class BuildInformation {
const buildInformation: IOctopusBuildInformation = {
BuildEnvironment: "Azure DevOps",
BuildNumber: environment.buildNumber,
BuildUrl: environment.teamCollectionUri.replace(/\/$/, "") + "/" + environment.projectName + "/_build/results?buildId=" + environment.buildId,
BuildUrl: environment.teamCollectionUri.replace(/\/$/, "") + "/" + environment.projectName + "/_build/index?buildId=" + environment.buildId,
Branch: branch,
VcsType: this.getVcsTypeFromProvider(environment.buildRepositoryProvider),
VcsRoot: environment.buildRepositoryUri,
Expand Down
2 changes: 1 addition & 1 deletion source/tasksLegacy/BuildInformation/BuildInformationV4/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async function run() {
const buildInformation: IOctopusBuildInformation = {
BuildEnvironment: "Azure DevOps",
BuildNumber: environment.buildNumber,
BuildUrl: environment.teamCollectionUri.replace(/\/$/, "") + "/" + environment.projectName + "/_build/results?buildId=" + environment.buildId,
BuildUrl: environment.teamCollectionUri.replace(/\/$/, "") + "/" + environment.projectName + "/_build/index?buildId=" + environment.buildId,
// @ts-expect-error
Branch: branch,
VcsType: getVcsTypeFromProvider(environment.buildRepositoryProvider),
Expand Down