Update ArgoCD CLI steps ActionType to be Octopus.Script #1637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
ActionTypeproperty of the community step templates that leverage ArgoCD CLI to perform app functions such as sync, set etc were incorrectly based on the "Run a Kubectl script" (Octopus.KubernetesRunScriptaction type).This meant that the only execution location these steps could run against were Kubernetes targets, despite not needing the Kubernetes context that Octopus provides with these step/target types.
The parameters and the steps themselve authenticate with the argocd CLI directly, and dont need the additional context.
A customer later informed us that having the need for a Kubernetes target was undesirable, when a woorker could do the same job.
Results
No longer need to run the steps on a K8s target.
Before
You had to run the scripts on a K8s target
After
You can run the steps on any location supported by the run a script step.
Note: Changing the ActionType does not change it for installed steps in a consuming process. Having reviewed telemetry with R&D, the impact (usage) is very low - only 1 usage on a customer instance.
The description has been updated to include a warning to reflect this and provide remediation advice (remove step and re-add to process).