Skip to content

Argo Image Update Step: Remove package purpose from package filtering #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rain-on wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Argo Image Update Step: Remove package purpose from package filtering #1744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d97d751
removed package purpose from package filtering
rain-on Jan 30, 2026
20c6084
tidy up
rain-on Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions source/Calamari/ArgoCD/VariablesExtensionMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,18 @@
using System.Linq;
using Calamari.ArgoCD.Models;
using Calamari.Common.Plumbing.Variables;
using Octopus.CoreUtilities.Extensions;

namespace Calamari.ArgoCD
{
public static class VariablesExtensionMethods
{
public static IList<string> GetContainerPackageNames(this IVariables variables)
{
var packageIndexes = variables.GetIndexes(PackageVariables.PackageCollection);
var packageReferences = (from packageIndex in packageIndexes
let image = variables.Get(PackageVariables.IndexedImage(packageIndex), string.Empty)
let purpose = variables.Get(PackageVariables.IndexedPackagePurpose(packageIndex), string.Empty)
where purpose.Equals("DockerImageReference", StringComparison.Ordinal)
select image)
.ToList();

return packageReferences;
return variables.GetIndexes(PackageVariables.PackageCollection)
.Select(pi => variables.Get(PackageVariables.IndexedImage(pi), string.Empty))
.Where(name => !name.IsNullOrEmpty())
.ToList();
}

public static (ProjectSlug Project, EnvironmentSlug Environment, TenantSlug? Tenant) GetDeploymentScope(this IVariables variables)
Expand Down