Removes all preprocessor statements and defined constants #1720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APErebus
commented
Jan 14, 2026
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.DotNet.Analyzers.Compatibility" Version="0.2.12-alpha"> |
Contributor
Author
There was a problem hiding this comment.
we don't need this as there is no cross-framework compatibility to worry about anymore
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)' == 'Debug' "> | ||
| <DefineConstants>$(DefineConstants);DEBUG</DefineConstants> |
Contributor
Author
There was a problem hiding this comment.
DEBUG is an implicitly defined constant for this configuration
flin-8
reviewed
Jan 14, 2026
| using (var basisFile = new TemporaryFile(PackageBuilder.BuildSamplePackage("Acme.Web", "1.0.0"))) | ||
| using (var signatureFile = new TemporaryFile(basisFile.FilePath + ".octosig")) | ||
| { | ||
| #if USE_OCTODIFF_EXE |
Contributor
There was a problem hiding this comment.
What dictates USE_OCTODIFF_EXE?
Contributor
Author
There was a problem hiding this comment.
It was a pre-processor constant for .NET 4.6.2... Example in 2025.4
Jtango18
reviewed
Jan 14, 2026
| static SubstitutionsFixture() | ||
| { | ||
| #if NETCORE | ||
| Encoding.RegisterProvider(CodePagesEncodingProvider.Instance); // Required to use code pages in .NET Standard |
Contributor
There was a problem hiding this comment.
nit: Kill the comment - it's superfluous
Jtango18
reviewed
Jan 14, 2026
Jtango18
reviewed
Jan 14, 2026
Jtango18
approved these changes
Jan 14, 2026
Contributor
Jtango18
left a comment
Jtango18
left a comment
There was a problem hiding this comment.
Some minor nit-needles in the haystack, otherwise...looks dope! SHIP IT!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that every project is .NET 8 and there is no .NET Framework, we can remove any pre-processor
#ifstatements and extra defined constants.ref MD-1413