Tweak logging and add some missing tests #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flin-8
force-pushed
the
frank/sourcetype
branch
from
4b58d09 to
1dce8cb
Compare
flin-8
changed the title
flin-8
commented
Jan 13, 2026
| void GenerateHelmAnnotationLogMessages(Application app, string subPath) | ||
| void LogMissingHelmImageReplacePath(Uri helmSourceIsMissingImagePathAnnotation) | ||
| { | ||
| log.WarnFormat("Argo CD Application '{0}' contains a helm chart ({1}), however the application is missing Octopus-specific annotations required for image-tag updating in Helm.", |
Contributor
Author
There was a problem hiding this comment.
Make the warning message more consistent
flin-8
commented
Jan 13, 2026
|
|
||
| [Test] | ||
| public void UpdateImages_HelmWithImageMatches_CommitsChangesToGitAndReturnsUpdatedImages() | ||
| // [Test] |
Contributor
Author
There was a problem hiding this comment.
This is failing atm, will be fixed by #1711
flin-8
commented
Jan 13, 2026
| AssertOutputVariables(false, matchingApplicationTotalSourceCounts: "2", matchingApplicationMatchingSourceCounts: "0"); | ||
| } | ||
|
|
||
| // [Test] |
Contributor
Author
There was a problem hiding this comment.
This is failing atm, will be fixed by #1711
flin-8
changed the title
rain-on
reviewed
Jan 15, 2026
| return this; | ||
| } | ||
|
|
||
| public ArgoCDApplicationBuilder WithSource<T>(T source, string sourceType) where T : ApplicationSource |
rain-on
approved these changes
Jan 15, 2026
Contributor
rain-on
left a comment
rain-on
left a comment
There was a problem hiding this comment.
1 nit - otherwise shipit
| { | ||
| applicationSources.Add(source); | ||
| applicationSourceTypes.Add(sourceType); | ||
| if (sourceType != null) |
Contributor
There was a problem hiding this comment.
can we enable nullability so that string? would enforce nullability?
Contributor
Author
There was a problem hiding this comment.
But that's a bigger change, so we should do that separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filling in some missing tests before a big refactor