Adopt Octoslack plugin#1434
Conversation
jneilliii
left a comment
There was a problem hiding this comment.
Small change required on this PR, and you will also need to enable issues on your fork before we'll accept.
Small warning as it relates to the changes on your fork. I've seen it in the past where maintainer will miss/forget to bump the version in both pyproject.toml (formerly setup.py) and inside the __init__.py file as well like you've done here. This isn't a show stopper, but on future updates just make sure to update both files prior to tagging the release.
| title: Octoslack | ||
| description: An OctoPrint plugin for monitoring your printer and prints via Slack, Mattermost, Pushbullet, Pushover, Rocket.Chat, Discord, Riot/Matrix, or Microsoft Teams | ||
| author: Chris Fraschetti | ||
| author: Šárka Hawke |
There was a problem hiding this comment.
we prefer you keep previous authors rather than replace single author attribute.
authors:
- Šárka Hawke
- Chris Fraschetti
Maybe it's better to remove the version override in |
|
I have added original author back to Octoslack.md file for |
|
Thank you very much for these fixes. I have merged your PR @jacopotediosi |
jneilliii
left a comment
There was a problem hiding this comment.
It seems that issues are still not enabled in your forked repository. Once that is done I am ready to approve and merge.
|
authors were also not updated as suggested, but reverted to previous author. |
|
Oh yeah, my bad authors have been updated. It should be correct now @jneilliii |
|
@misconfigurations you have not yet enabled the issues tab in your repository settings |
|
I enabled it now @jacopotediosi |
|
I confirm, you should be okay now. Please wait for Jim. |
|
Thank you |
Adopting Octoslack plugin after abandonment #1432
I used #1420 PR as an example on how to make adoption PR. I even made same mistake with changing the date in OctoSlack.md file which I reverted back to original.