Skip to content

Adopt Octoslack plugin#1434

Merged
jneilliii merged 5 commits intoOctoPrint:gh-pagesfrom
misconfigurations:gh-pages
May 9, 2026
Merged

Adopt Octoslack plugin#1434
jneilliii merged 5 commits intoOctoPrint:gh-pagesfrom
misconfigurations:gh-pages

Conversation

@misconfigurations
Copy link
Copy Markdown
Contributor

Adopting Octoslack plugin after abandonment #1432

I used #1420 PR as an example on how to make adoption PR. I even made same mistake with changing the date in OctoSlack.md file which I reverted back to original.

Copy link
Copy Markdown
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change required on this PR, and you will also need to enable issues on your fork before we'll accept.

Small warning as it relates to the changes on your fork. I've seen it in the past where maintainer will miss/forget to bump the version in both pyproject.toml (formerly setup.py) and inside the __init__.py file as well like you've done here. This isn't a show stopper, but on future updates just make sure to update both files prior to tagging the release.

Comment thread _plugins/Octoslack.md Outdated
title: Octoslack
description: An OctoPrint plugin for monitoring your printer and prints via Slack, Mattermost, Pushbullet, Pushover, Rocket.Chat, Discord, Riot/Matrix, or Microsoft Teams
author: Chris Fraschetti
author: Šárka Hawke
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we prefer you keep previous authors rather than replace single author attribute.

authors:
    - Šárka Hawke
    - Chris Fraschetti

@jacopotediosi
Copy link
Copy Markdown
Member

jacopotediosi commented May 6, 2026

bump the version in both pyproject.toml (formerly setup.py) and inside the __init__.py file

Maybe it's better to remove the version override in __init__.py and just keep the one in pyproject?

@misconfigurations
Copy link
Copy Markdown
Contributor Author

I have added original author back to Octoslack.md file

for __init__.py and pyproject.toml I bumped version up in both files before releasing. Both files should have version 2.2.1

Copy link
Copy Markdown
Member

@jacopotediosi jacopotediosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things I want to take this adoption as an opportunity to clean up, such as unused imports, comparisons with None, etc.

Also, your get_update_information method still points to the old repository's URL.

Expect my PR within a few hours. I sent you this PR.

@misconfigurations
Copy link
Copy Markdown
Contributor Author

Thank you very much for these fixes. I have merged your PR @jacopotediosi

Copy link
Copy Markdown
Member

@jacopotediosi jacopotediosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the plugin code and the one in this PR now look good to me

Copy link
Copy Markdown
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that issues are still not enabled in your forked repository. Once that is done I am ready to approve and merge.

@jneilliii
Copy link
Copy Markdown
Contributor

authors were also not updated as suggested, but reverted to previous author.
replace author: Chris Fraschetti with

authors:
    - Šárka Hawke
    - Chris Fraschetti

@misconfigurations
Copy link
Copy Markdown
Contributor Author

Oh yeah, my bad

authors have been updated. It should be correct now @jneilliii

@jacopotediosi
Copy link
Copy Markdown
Member

jacopotediosi commented May 9, 2026

@misconfigurations you have not yet enabled the issues tab in your repository settings

@misconfigurations
Copy link
Copy Markdown
Contributor Author

I enabled it now @jacopotediosi

@jacopotediosi
Copy link
Copy Markdown
Member

I confirm, you should be okay now. Please wait for Jim.

@misconfigurations
Copy link
Copy Markdown
Contributor Author

Thank you

Copy link
Copy Markdown
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jneilliii jneilliii merged commit a45327e into OctoPrint:gh-pages May 9, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OctoPrint Backlog May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants