Skip to content

Allow to advertise p2p service via NodePort or LodeBalancer, allow to use secrets from elsewhere #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matilote wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Allow to advertise p2p service via NodePort or LodeBalancer, allow to use secrets from elsewhere #53

matilote wants to merge 35 commits into from

Conversation

@matilote
Copy link

@matilote matilote commented Jul 29, 2024

  • added separate p2p service to expose ports on TCP/UDP protocols
  • allow to expose p2p service via NodePort or LodeBalancer in addition to ClusterIp
  • set externalIp dynamically by using init container
  • make usage of secrets conditional to allow fetching them through init containers or externalSecrets
  • make readiness and liveness probes conditional

matilote and others added 30 commits May 28, 2024 21:03
@matilote
make secrets optional
82e9155
@matilote
add missing volumes
3d01aef
@matilote
add udp port for p2p
de10abf
@matilote
optional readiness and liveness
6c589df
@0xDones
Update servicemonitor.yaml
daee5e7
@matilote
Merge pull request #1 from refl3ction/patch-1
4d667cf 
fix: service monitor port for charon
@matilote
Merge branch 'ObolNetwork:main' into main
df73a96
@0xDones
feat: prefix prometheus resources with release name
1285f2c
@0xDones
feat: add resources field to Prometheus
532bbfe
@0xDones
fix: remove dash condition
c1e0387
@matilote
Merge pull request #2 from 0xDones/feat/prometheus-name
33a6859 
feat: add prefix to prometheus resources
@0xDones
fix: config map reference
d34bbb2
@matilote
Merge pull request #3 from 0xDones/feat/prometheus-name
82a3036 
fix: config map reference
@matilote
add separate p2p service to allow NodePort exposure
e4d4062
@matilote
remove redundant value
5cec571
@matilote
adding nodePort init stuff
1f6e37f
@matilote
fix null ref
2ec0e3b
@matilote
fix yaml
2b015f5
@matilote
fix yaml
d90a4bd
@matilote
try to exec charon
db9d9f2
@matilote
remove exec
6921a3f
@matilote
try different approach
adba115
@matilote
use hardcoded nodePort value
434eec7
@matilote
use host ip
7a64618
@matilote
remove $ sign
e0572c8
@matilote
remove default externalIp
4ce0b15
@matilote
Merge pull request #4 from NethermindEth/feat/nodePortCharon
b311308 
Feat/node port charon
@matilote
use single line appropproach
38c0ed6
@matilote
use previous approach
a3fffcb
@matilote
Merge pull request #5 from NethermindEth/feat/nodePortCharon
bb188ef 
use single line appropproach
@matilote matilote requested a review from a team as a code owner July 29, 2024 19:45
aly-obol
aly-obol previously approved these changes Aug 8, 2024
View reviewed changes
@matilote matilote requested a review from aly-obol October 30, 2024 08:44
@aly-obol aly-obol requested review from aly-obol and apham0001 and removed request for aly-obol November 19, 2024 16:19
@aly-obol
Copy link
Collaborator

aly-obol commented Nov 19, 2024

@apham0001 can you please have a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apham0001 apham0001 Awaiting requested review from apham0001

@aly-obol aly-obol Awaiting requested review from aly-obol

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matilote @aly-obol @0xDones