Skip to content

Upgraded from Website App v2.2 to v3.0#2940

Open
sydseter wants to merge 3 commits intomasterfrom
webapp-v3
Open

Upgraded from Website App v2.2 to v3.0#2940
sydseter wants to merge 3 commits intomasterfrom
webapp-v3

Conversation

@sydseter
Copy link
Copy Markdown
Collaborator

@sydseter sydseter commented May 7, 2026

Description

In this pull-request:

  • Upgrade webapp to version 3.0 for copi.owasp.org and cornucopia.owasp.org
  • Removed the mapping table on the card
  • Fixes a couple of bugs related to the language picker and the ASVS index and CAPEC map.
  • Changing the release pipeline from releasing v2.2 to be releasing v3.0

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.

Resolved or fixed issue:

AI Tool Disclosure

  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: [e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.]
    • LLMs and versions: [e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro etc.]
    • Prompts: [Summarize the key prompts or instructions given to the AI tools]

Affirmation

Copilot AI review requested due to automatic review settings May 7, 2026 22:51
@sydseter sydseter requested review from cw-owasp and rewtd as code owners May 7, 2026 22:51
@sydseter sydseter changed the title Upgraded from WebSite App v2.2 to v3.0 Upgraded from Website App v2.2 to v3.0 May 7, 2026
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 7, 2026

All good ✅

Comment thread cornucopia.owasp.org/src/domain/suit/suitController.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the “webapp” deck used by both cornucopia.owasp.org (SvelteKit) and copi.owasp.org (Phoenix) from v2.2 to v3.0, aligning routing/mapping behavior (ASVS 5.0, CAPEC) and updating tests and UI to match the new deck content.

Changes:

  • Switch “webapp” latest deck version to 3.0 and update language/version lookups and related tests.
  • Wire CAPEC data loading into the Cornucopia card pages (to support the CAPEC→ASVS mapping UI).
  • Remove the mapping table display from Copi’s webapp/ecommerce card view and update Copi tests/data to use webapp 3.0.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/+page.server.ts Select ASVS version based on latest deck (v3.0 → ASVS 5.0) and load CAPEC data for webapp v3+.
cornucopia.owasp.org/src/routes/cards/[card]/+page.svelte Pass capecData into the card display component.
cornucopia.owasp.org/src/routes/cards/[card]/+page.server.ts Compute ASVS version via latest deck; load CAPEC data; use per-edition+version languages.
cornucopia.owasp.org/src/routes/api/cre/[edition]/[lang]/server.test.ts Adjust test stubs to reflect webapp latest v3.0.
cornucopia.owasp.org/src/lib/services/deckService.ts Set webapp latest to v3.0 and add per-edition+version language lookup.
cornucopia.owasp.org/src/lib/services/deckService.test.ts Update tests for new latest version and language support.
cornucopia.owasp.org/src/lib/components/cardPreview.svelte Remove WebApp mapping rendering from the preview component.
cornucopia.owasp.org/src/domain/suit/suitController.ts Update webapp deck version to 3.0 in suit listing logic.
copi.owasp.org/test/copi_web/live/player_live/show_test.exs Update webapp card version fixtures to 3.0.
copi.owasp.org/test/copi_web/live/player_live_test.exs Update webapp card version fixtures to 3.0.
copi.owasp.org/test/copi_web/live/game_live/show_test.exs Expect Copi “latest_version(webapp)” to be 3.0.
copi.owasp.org/test/copi_web/live/game_live/show_pure_test.exs Expect Copi “latest_version(webapp)” to be 3.0.
copi.owasp.org/test/copi_web/live/game_live_test.exs Update webapp card version fixtures and latest_version assertion to 3.0.
copi.owasp.org/priv/repo/migrations/20260706100557_populate_cards_for_webapp3.exs Add migration to populate webapp v3.0 cards into Copi DB.
copi.owasp.org/priv/repo/cornucopia/webapp-cards-3.0-en.yaml Add webapp v3.0 English card data for Copi.
copi.owasp.org/lib/copi/migrations/card_migration.ex Change how webapp mapping fields are populated during mapping import.
copi.owasp.org/lib/copi_web/live/game_live/show.ex Update webapp latest version to 3.0.
copi.owasp.org/lib/copi_web/controllers/card_html/show.html.heex Remove mapping table section from webapp/ecommerce card rendering.
copi.owasp.org/assets/package-lock.json Update lockfile entries for Phoenix-related JS deps and tooling.
Files not reviewed (1)
  • copi.owasp.org/assets/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

cornucopia.owasp.org/src/domain/suit/suitController.ts:12

  • SuitController hard-codes the webapp language list and is now out of sync with DeckService for webapp v3.0 (missing hi and uk, which are included in DeckService’s v3.0 languages). This can cause language-specific suit/card navigation to silently omit those languages. Consider deriving these decks/languages from DeckService (or at least updating the webapp language list to include hi and uk) to avoid drift.
    private static decks = [{edition: 'mobileapp', version: '1.1'}, {edition: 'webapp', version: '3.0'}, {edition: 'companion', version: '1.0'}];
    private static languages : Map<string, { lang: string[] }> = new Map<string, { lang: string[] }>([
        ['mobileapp', {lang: ['en']}], 
        ['webapp', {lang: ['en', 'es', 'fr', 'nl', 'no_nb', 'pt_br', 'pt_pt', 'ru', 'it']}],
        ['companion', {lang: ['en']}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants