fix: remove unused scores field from DealtCard schema and database#2711
Open
Adarshkumar0509 wants to merge 2 commits intoOWASP:masterfrom
Open
fix: remove unused scores field from DealtCard schema and database#2711Adarshkumar0509 wants to merge 2 commits intoOWASP:masterfrom
Adarshkumar0509 wants to merge 2 commits intoOWASP:masterfrom
Conversation
Adarshkumar0509
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2499
Description
Remove unused
scoresboolean field from theDealtCardschema and database.The
:scoresfield existed in bothdealt_card.exand the originalcreate_dealt_cardsmigration but was never read, written, or referencedanywhere in the codebase. Scoring is calculated dynamically via vote
counting in
scoring_cards/2incornucopia.ex— the field was neverneeded.
Changes:
field :scores, :booleanfromlib/copi/cornucopia/dealt_card.exscorescolumn from thedealt_cardstableResolved or fixed issue: #2499
AI Tool Disclosure
Affirmation