Skip to content

fix: handle_event(next_round) missing early return causes double broadcast (#2418) #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sydseter merged 2 commits into from
Apr 8, 2026
Merged

fix: handle_event(next_round) missing early return causes double broadcast (#2418) #2707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80bdb06
fix: handle_event(next_round) control-flow bug - missing early return…
immortal71 Mar 20, 2026
7fb5685
Merge branch 'master' into fix/2418-next-round-double-broadcast
sydseter Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions copi.owasp.org/lib/copi_web/live/player_live/show.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,13 @@ defmodule CopiWeb.PlayerLive.Show do
if last_round?(game) do
Copi.Cornucopia.update_game(game, %{finished_at: DateTime.truncate(DateTime.utc_now(), :second)} )
end
end

{:ok, updated_game} = Game.find(game.id)
{:ok, updated_game} = Game.find(game.id)

CopiWeb.Endpoint.broadcast(topic(updated_game.id), "game:updated", updated_game)
CopiWeb.Endpoint.broadcast(topic(updated_game.id), "game:updated", updated_game)

{:noreply, assign(socket, :game, updated_game)}
{:noreply, assign(socket, :game, updated_game)}
end
end

@impl true
Expand Down
Loading