Update latests languages for mobileapp (hi, uk) as per maintainer gui…#2682
Update latests languages for mobileapp (hi, uk) as per maintainer gui…#2682prasunsrivastav123-lang wants to merge 6 commits intoOWASP:masterfrom
Conversation
|
@prasunsrivastav123-lang you have a conflict |
|
@sydseter conflicts are resolve now |
|
You will need to add a card for each translation to as well.e.g: That ensures that all the cards for the new translations gets prerendered. |
|
@sydseter Thanks for the clarification! I've added both card and edition prerender entries for the new translations (hi, uk) to ensure they are fully generated and available in the static build. |
|
It’s not serving the endpoints. You should have a look at it. |
|
@sydseter Thanks for pointing that out! I’ve added them now and will push the fix. |
| '/edition/webapp/VE2/3.0/hi', | ||
| '/edition/webapp/VE2/3.0/uk' | ||
| '/edition/webapp/VE2/3.0/uk', | ||
| '/card/mobileapp/PC2/1.1/en', |
There was a problem hiding this comment.
'/edition/mobileapp/PC2/1.1/en',
'/edition/mobileapp/PC2/1.1/uk',
'/edition/mobileapp/PC2/1.1/hi',
| '/card/mobileapp/PC2/1.1/en', | ||
| '/card/mobileapp/PC2/1.1/uk', | ||
| '/card/mobileapp/PC2/1.1/hi', | ||
| '/card/webapp/VE2/2.2/es', |
There was a problem hiding this comment.
Remove this:
'/card/webapp/VE2/2.2/es',
'/card/webapp/VE2/2.2/it',
'/card/webapp/VE2/2.2/nl',
'/card/webapp/VE2/2.2/fr',
'/card/webapp/VE2/2.2/pt_pt',
'/card/webapp/VE2/2.2/pt_br',
'/card/webapp/VE2/2.2/no_nb',
'/card/webapp/VE2/2.2/ru',
'/card/webapp/VE2/3.0',
'/card/webapp/VE2/3.0/en',
'/card/webapp/VE2/3.0/es',
'/card/webapp/VE2/3.0/it',
'/card/webapp/VE2/3.0/nl',
'/card/webapp/VE2/3.0/fr',
'/card/webapp/VE2/3.0/pt_pt',
'/card/webapp/VE2/3.0/pt_br',
'/card/webapp/VE2/3.0/no_nb',
'/card/webapp/VE2/3.0/ru',
|
You should also change: cornucopia.owasp.org\src\routes\api\cre[edition][lang]+server.ts Instead of: if (!languages.includes(lang)) error(404, 'Language not found. Only: ' + languages.join(', ') + ' are supported.'); Do: if (!(DeckService.getLanguages(edition)).includes(lang)) error(404, 'Language not found. Only: ' + DeckService.getLanguages(edition).join(', ') + ' are supported.'); You can then remove: const languages = ["en", "no_nb", "nl", "es", "pt_pt", "pt_br", "ru", "fr", "it", "hi", "uk"] |
|
@sydseter Thanks for the detailed feedback! I’m currently out of station, but I’ve noted all the changes (removing unnecessary prerender entries and updating the API validation). I’ll implement everything and push the fixes tomorrow. |
|
No rush, Monday is also fine. |
Description
This updates the
latestslist to include additional languages (hi, uk) for the mobileapp edition, .fixed issue #2663
AI Tool Disclosure
[e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.][e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro etc.][Summarize the key prompts or instructions given to the AI tools]Affirmation