Skip to content

Improved boilerplate, github link scrolling to readme, and completing…#896

Open
robvanderveer wants to merge 1 commit intoOWASP:mainfrom
robvanderveer:main
Open

Improved boilerplate, github link scrolling to readme, and completing…#896
robvanderveer wants to merge 1 commit intoOWASP:mainfrom
robvanderveer:main

Conversation

@robvanderveer
Copy link
Copy Markdown
Collaborator

… the list of standards with the new AI ones

@robvanderveer robvanderveer marked this pull request as ready for review April 30, 2026 10:03
@Bornunique911
Copy link
Copy Markdown
Contributor

Bornunique911 commented May 1, 2026

Hi @robvanderveer sir 👋

It looks like the "Check frontend formatting" CI step is failing because the changes in SearchPage.tsx don’t quite match the project’s Prettier style.

Running the formatter locally will fix it. Inside your branch, just do:

cd application/frontend
yarn install --frozen-lockfile
cd ../..
yarn prettier --write "application/frontend/src/**/*.{ts,tsx,js}"

That will automatically update this PR and the CI should go green.

If you’d prefer, I can also open a small PR against your fork with the formatting already applied – just let me know.

Cheers, sir!

Error Log from the workflow :

Run yarn prettier --check "application/frontend/src/**/*.{ts,tsx,js}"
yarn run v1.22.22
$ /home/runner/work/OpenCRE/OpenCRE/node_modules/.bin/prettier --check 'application/frontend/src/**/*.{ts,tsx,js}'
Checking formatting...
[warn] application/frontend/src/pages/Search/Search.tsx
[warn] Code style issues found in the above file. Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@robvanderveer
Copy link
Copy Markdown
Collaborator Author

Yes please, @Bornunique911, could you do that for me please?
And could you share what it is in the formatting that is off, is it in the free text going to wide? I'd like to know the rules so I can apply them while typing instead of relying on the linter's scrutiny.

@Bornunique911
Copy link
Copy Markdown
Contributor

Bornunique911 commented May 1, 2026

Yes please, @Bornunique911, could you do that for me please?
And could you share what it is in the formatting that is off, is it in the free text going to wide? I'd like to know the rules so I can apply them while typing instead of relying on the linter's scrutiny.

Hi @robvanderveer sir,

Of course, I'll open a small PR against your fork with the formatting applied — I'll do that shortly.

As for what’s actually off: Prettier enforces a consistent style automatically. In this case, the most likely issue is line length — the default print width is 80 characters, so if any line (code or free text) exceeds that, Prettier will reformat it. There might also be minor indentation or spacing inconsistencies. You can see the exact diff by running yarn prettier --check locally (it will list the file and the nature of the issue), or by looking at the PR I’ll open — the diff will show exactly what changed.

To apply the rules while typing, the easiest way is to set up your editor to format-on-save using the same Prettier config that the project uses. That way you never have to think about it. I can include a note on that in the PR as well if you like.

Cheers, sir!

@Bornunique911
Copy link
Copy Markdown
Contributor

Hi @robvanderveer sir,

The formatting CI failure in this PR has now been resolved by PR #898. Merging #898 will apply the Prettier formatting fixes and get the frontend check passing.

Thanks again for your patience. Happy to help with anything else.

Cheers, sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants