Improved boilerplate, github link scrolling to readme, and completing…#896
Improved boilerplate, github link scrolling to readme, and completing…#896robvanderveer wants to merge 1 commit intoOWASP:mainfrom
Conversation
… the list of standards with the new AI ones
|
Hi @robvanderveer sir 👋 It looks like the Running the formatter locally will fix it. Inside your branch, just do: cd application/frontend
yarn install --frozen-lockfile
cd ../..
yarn prettier --write "application/frontend/src/**/*.{ts,tsx,js}"That will automatically update this PR and the CI should go green. If you’d prefer, I can also open a small PR against your fork with the formatting already applied – just let me know. Cheers, sir! Error Log from the workflow :Run yarn prettier --check "application/frontend/src/**/*.{ts,tsx,js}"
yarn run v1.22.22
$ /home/runner/work/OpenCRE/OpenCRE/node_modules/.bin/prettier --check 'application/frontend/src/**/*.{ts,tsx,js}'
Checking formatting...
[warn] application/frontend/src/pages/Search/Search.tsx
[warn] Code style issues found in the above file. Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1. |
|
Yes please, @Bornunique911, could you do that for me please? |
Hi @robvanderveer sir, Of course, I'll open a small PR against your fork with the formatting applied — I'll do that shortly. As for what’s actually off: Prettier enforces a consistent style automatically. In this case, the most likely issue is line length — the default print width is 80 characters, so if any line (code or free text) exceeds that, Prettier will reformat it. There might also be minor indentation or spacing inconsistencies. You can see the exact diff by running To apply the rules while typing, the easiest way is to set up your editor to format-on-save using the same Prettier config that the project uses. That way you never have to think about it. I can include a note on that in the PR as well if you like. Cheers, sir! |
|
Hi @robvanderveer sir, The formatting CI failure in this PR has now been resolved by PR #898. Merging #898 will apply the Prettier formatting fixes and get the frontend check passing. Thanks again for your patience. Happy to help with anything else. Cheers, sir! |
… the list of standards with the new AI ones