feat(frontend): Refine Gap Analysis link strength categorization (Weak threshold 20 -> 7) #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce tiered gap analysis queries (strong → medium → wildcard) - Stop traversal early when strong or medium paths exist - Preserve existing scoring and semantics - Add unit test to verify Tier-3 traversal is skipped when not needed Fixes OWASP#506
Contributor
Author
|
Hi @northdpole Verification Report
Always open to iterating further based on your guidance. I'm really learning a lot from this process—thanks for the review and the honest responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Stacked PR: This PR is built on top of PR #716 (Backend Optimization). Please merge #716 first.
Summary
This PR adjusts the categorization logic for Gap Analysis links in the frontend. It lowers the score threshold for "Weak" links from
20to7to better reflect the true quality of connections, as requested by the maintainers.Motivation
The maintainer noted:
Previously, a "Weak" link was defined as having a penalty score of
20or higher. This score is practically unreachable in normal operation (requires ~10 hops of "related" links), causing truly weak connections to be mislabeled as "Average" or "Strong". This change aligns the UI with the maintainer's request and the user's intuitive understanding of link strength.Changes
>= 20to>= 7.>= 20to>= 7.Related Issue
Verification
"Weakly connected likely to have small or no overlap"corresponds to score 7.Checklist