refactor(version): remove hardcoded __version__, resolve from setup.py only#55
Merged
Conversation
…lve from setup.py only Version is now read via importlib.metadata (installed) or by parsing setup.py (source). setup.py is the single source of truth — no hardcoded constant to drift out of sync.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| match = re.search(r'version="([^"]+)"', f.read()) | ||
| if match: | ||
| return match.group(1) | ||
| except Exception: |
Check notice
Code scanning / CodeQL
Empty except
Collaborator
Author
There was a problem hiding this comment.
resolved this issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the hardcoded
__version__ = "2026.2.23"constant fromdocksec.py. Version is now read dynamically sosetup.pyis the single source of truth — no risk of the two drifting out of sync.How it works
get_version()resolution order:importlib.metadata.version("docksec")— works when installed via pipversion=fromsetup.pyon disk — works when running from source"unknown"as a last resortBefore vs After
Before — two places to update on every release:
setup.py:version="2026.2.23"docksec.py:__version__ = "2026.2.23"(could drift)After — one place only:
setup.py:version="2026.4.2"docksec.py: no hardcoded version constantType of Change
Checklist