ci: set least-privilege permissions on workflow token#844
Merged
Conversation
Set an explicit least-privilege permissions block so the workflow GITHUB_TOKEN is scoped to contents: read instead of inheriting the repository default. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Collaborator
|
As this is only a standard, we don't need to harden the CI imo. But thanks for thinking about it! :) |
Member
|
There are so many GitHub attacks and since I created the repo, the identity is under my name. I'm going to go for it and merge this nice addition in... |
Contributor
Author
Thank you @jmanico |
Member
|
And a PS: @RicoKomenda meant well, we are desperately trying to avoid new automation. But if any of these libraries get compromised by prompt injection type attacks, we're screwed. This helps. Thank you. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I work on software supply chain security and have been hardening GitHub Actions workflows across OSS projects.
Each of these workflows runs without a top-level
permissions:block, so itsGITHUB_TOKENinherits the repository (or org) default, which is frequently read/write for all scopes. This PR setspermissions: contents: readat the workflow level for.github/workflows/markdown_linter.yml,.github/workflows/spell-check.yml, which is all these jobs need (checkout plus the build/test steps). Scoping the token to read-only shrinks what a compromised step or dependency can do, a concern made concrete by the March 2025tj-actions/changed-filescompromise (CVE-2025-30066), where a leaked write-scopedGITHUB_TOKENwas the blast radius.No job behavior changes; the steps already only read the repository.