Replace custom sonarqube generation with sonar-report#286
Merged
davewichers merged 1 commit intoOWASP-Benchmark:masterfrom Jan 28, 2025
Merged
Replace custom sonarqube generation with sonar-report#286davewichers merged 1 commit intoOWASP-Benchmark:masterfrom
davewichers merged 1 commit intoOWASP-Benchmark:masterfrom
Conversation
Contributor
|
@darkspirit510 - I merged this, but (per my emails) there are two issues with it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @davewichers, I replaced custom report generation with sonar-report. Important: BenchmarkUtils requires PR 152 to be merged, because one field got removed which is expected to be present leading to zero results in score.
Recreated PR. Forgot to pull main 😅