Deprecated the 'windows_view' element and attribute per #329#330
Open
vanderpol wants to merge 1 commit into
Open
Deprecated the 'windows_view' element and attribute per #329#330vanderpol wants to merge 1 commit into
vanderpol wants to merge 1 commit into
Conversation
balleman-ctr
approved these changes
May 28, 2026
balleman-ctr
left a comment
balleman-ctr
left a comment
There was a problem hiding this comment.
I don't see any problems with merging.
Two observations that could be addressed separately and more generally:
- these deprecations do not add schematron, but some others have it
- there are some indentation inconsistencies
g-burkholder
approved these changes
May 29, 2026
g-burkholder
left a comment
g-burkholder
left a comment
There was a problem hiding this comment.
We aren't using windows_view in our active content, and I'm not aware of any intent to use it in the future. I concur with deprecating it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documented the unused 'windows_view' as deprecated in 5.12.3 and to be removed in 6.0.1