Skip to content

centralize b-value management at initialization (#155)#165

Open
Devguru-codes wants to merge 1 commit into
OSIPI:mainfrom
Devguru-codes:issue#155
Open

centralize b-value management at initialization (#155)#165
Devguru-codes wants to merge 1 commit into
OSIPI:mainfrom
Devguru-codes:issue#155

Conversation

@Devguru-codes
Copy link
Copy Markdown
Contributor

  • Remove bvalues parameter from all 27 algorithm ivim_fit() and ivim_fit_full_volume() signatures in src/standardized/
  • All algorithms now access b-values via self.bvalues exclusively
  • Add **kwargs to algorithms that lacked it (OJ_GU_seg, PV_MUMC, PvH_KB_NKI, TF_reference)
  • OsipiBase.osipi_fit() and osipi_fit_full_volume() enforce ValueError if bvalues not set at init
  • Update all test files to pass bvalues at OsipiBase(...) init
  • Update WrapImage production wrappers to use new API
  • Remove now-redundant bvalue equality checks in DL algorithms

fixes #155

- Remove bvalues parameter from all 27 algorithm ivim_fit() and
  ivim_fit_full_volume() signatures in src/standardized/
- All algorithms now access b-values via self.bvalues exclusively
- Add **kwargs to algorithms that lacked it (OJ_GU_seg, PV_MUMC,
  PvH_KB_NKI, TF_reference)
- OsipiBase.osipi_fit() and osipi_fit_full_volume() enforce ValueError
  if bvalues not set at init
- Update all test files to pass bvalues at OsipiBase(...) init
- Update WrapImage production wrappers to use new API
- Remove now-redundant bvalue equality checks in DL algorithms

Files modified: 33 (27 algorithms + OsipiBase + 3 tests + 2 wrappers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Changing b-values

1 participant