add pa11y task and CI integration#1393
Open
Bubballoo3 wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
Looks like it is failing as expected but not marking as failed |
Contributor
Author
|
This seems to be working better, but we will have to wait for OSC/ood-documentation-build#25 before we can see it run and merge |
Remove conditional check for pull request event in accessibility scan step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1386. May need a bit of modification to get the behavior we want, but will have to wait for OSC/ood-documentation-build#25 before the task will run successfully.
For everything besides how the CI actually performs, you can pull down the linked PR from the build repo, build the image, then edit the image name in the Rakefile to
:latest. Then you should be able to run rake scan successfully.rake scanshould work successfully on latest, and fail on release_4.1