OS-244 #246 Adding Datafordeler address lookup#327
Open
stankut wants to merge 5 commits into
Open
Conversation
jekuaitk
reviewed
May 22, 2026
Contributor
jekuaitk
left a comment
jekuaitk
left a comment
There was a problem hiding this comment.
Should we bump os2web/os2web_datalookup version when it is merged to ensure an up-to-date version?
| '#pattern' => '^(\d{3},?)*$', | ||
| '#description' => $this->t('CSV list of municipalities codes, what will limit the address lookup.'), | ||
| '#title' => $this->t('Limit by municipality'), | ||
| '#pattern' => '^(\d{4})$', |
Contributor
There was a problem hiding this comment.
So only single municipality limits now? Also, would this not silently break existing webforms?
Collaborator
Author
There was a problem hiding this comment.
in the worst case, that would produce empty result (if there has been a multivalue value before).
We haven't talked about any migration logic, i also don't see any good migration logic here. I would say that is a manual process after migration, @ds-bellcom what is your say on this?
Comment on lines
+39
to
+40
| /** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DatafordelerAddressLookupInterface $datafordelerAddressLookup */ | ||
| $datafordelerAddressLookup = \Drupal::service('plugin.manager.os2web_datalookup')->createInstance('datafordeler_address_lookup'); |
Contributor
There was a problem hiding this comment.
We could move this into the if to avoid unnecessary instantiation when it is not a os2forms_dawa_address-element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.