Add 3 new element-wise vector operations#409
Closed
alexander-novo wants to merge 4 commits intoORNL:developfrom
Closed
Add 3 new element-wise vector operations#409alexander-novo wants to merge 4 commits intoORNL:developfrom
alexander-novo wants to merge 4 commits intoORNL:developfrom
Conversation
Collaborator
|
I suggest we merge #408, then #411 before this PR. @alexander-novo: #411 has some changes you may find helpful. Please rebase your branch to CC @shakedregev |
14 tasks
Collaborator
Author
|
Moved to #413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new vector operations:
elementwiseDividewhich performs likescale, but scales by the inverse of a diagonal matrix.elementwiseMaxwhich computes a vector whose elements are the maximum of the corresponding elements in the two input vectors.abswhich computes a vector whose elements are the absolute values of the corresponding element in the input vector.Proposed changes
N/A
Checklist
make testandmake test_installper testing instructions). Code tested on./examples/<your_example>.exe -hto get instructions how to run examples). Code tested on:-Wall -Wpedantic -Wconversion -Wextra.Further comments
N/A