Add cmake-format#409
Open
nkoukpaizan wants to merge 5 commits into
Open
Conversation
nkoukpaizan
added
development
nkoukpaizan
force-pushed
the
nicholson/cmake-format
branch
14 times, most recently
from
c28049e to
a32e319
Compare
Comment on lines
+2
to
+5
| target_link_libraries(PDSim | ||
| PUBLIC | ||
| GridKit::phasor_dynamics_components | ||
| GridKit::solvers_dyn | ||
| GridKit::Utilities | ||
| GridKit::testing) | ||
| target_include_directories(PDSim PRIVATE | ||
| ${GRIDKIT_THIRD_PARTY_DIR}/nlohmann-json/include | ||
| ${GRIDKIT_THIRD_PARTY_DIR}/magic-enum/include) | ||
| target_link_libraries(PDSim PUBLIC GridKit::phasor_dynamics_components GridKit::solvers_dyn | ||
| GridKit::Utilities GridKit::testing) | ||
| target_include_directories(PDSim PRIVATE ${GRIDKIT_THIRD_PARTY_DIR}/nlohmann-json/include | ||
| ${GRIDKIT_THIRD_PARTY_DIR}/magic-enum/include) |
Collaborator
There was a problem hiding this comment.
Is there a way to have it place elements one-per-line for lists that are too long? It's harder to read like this.
Collaborator
Author
There was a problem hiding this comment.
I agree. Still working on it.
Collaborator
Author
There was a problem hiding this comment.
It should be better now!
nkoukpaizan
force-pushed
the
nicholson/cmake-format
branch
6 times, most recently
from
0188cba to
eaafc29
Compare
nkoukpaizan
force-pushed
the
nicholson/cmake-format
branch
from
d36c31e to
21cca92
Compare
This reverts commit 2b4a551.
nkoukpaizan
force-pushed
the
nicholson/cmake-format
branch
from
ca7fa5f to
4316bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This add cmake-format hooks to harmonize CMake files.
I noticed the need for manual formatting in #394. I thought we had added this at the same time as Re::Solve, but it must have slipped through the cracks.
Proposed changes
.cmake-format.py. I tried to match the existing style as much as possible.cmake-formathook to.pre-commit-config.yaml.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Formatting-only changes.