Skip to content

Jacobian test for Exciter::SexsPti#396

Open
nkoukpaizan wants to merge 5 commits intodevelopfrom
nicholson/sexs-pti-jac-test
Open

Jacobian test for Exciter::SexsPti#396
nkoukpaizan wants to merge 5 commits intodevelopfrom
nicholson/sexs-pti-jac-test

Conversation

@nkoukpaizan
Copy link
Copy Markdown
Collaborator

Description

This mainly adds a Jacobian test for Exciter::SexsPti

Proposed changes

  • Added jacobian method to ExciterSexsPtiTests.hpp, testing the internal and bus Jacobians
  • Added LoadZIP smoke tests to SystemSingleComponentTests.hpp, and todo items for Exciter::SexsPti and Stabilizer::Ieeest smoke tests.
  • Minor comments and typo fixes

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

I'll work on abstracting away some of the Jacobian testing infrastructure to avoid having to duplicate the code.

@nkoukpaizan nkoukpaizan marked this pull request as ready for review May 7, 2026 18:14
@nkoukpaizan nkoukpaizan requested review from lukelowry and pelesh and removed request for lukelowry May 7, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant