Fixed the logic of the adaptive heat source integration#44
Open
Fixed the logic of the adaptive heat source integration#44
Conversation
…ls outside of bounding box. This is crude Riemann intergration using the midpoint rule, that is second-order accurate for smooth functions and axis-aligned hex cells.
kincaidkc
reviewed
Mar 31, 2025
Collaborator
kincaidkc
left a comment
kincaidkc
left a comment
There was a problem hiding this comment.
changes look good. a couple questions:
- do these changes result in any speedup vs. the original version of the code?
- would it make sense to add logic to turn off the integration in regions of the mesh that are well-refined?
| { | ||
| vector dx = cmptDivide(cellBb.span(), vector(nPts)); | ||
| scalar I = 0.0; | ||
| scalar count = 0.0; |
Collaborator
There was a problem hiding this comment.
this should probably be a label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated logic removes integration points outside of cell bounding box. This is a crude Riemann integration using the midpoint rule, that is second-order accurate for smooth functions and axis-aligned hexahedral cells.