Skip to content

Simplify findFishboneLateralsWellBoreParts #13776

Open
magnesj wants to merge 2 commits intoOPM:devfrom
magnesj:simplify-fishbones-trans-calc
Open

Simplify findFishboneLateralsWellBoreParts #13776
magnesj wants to merge 2 commits intoOPM:devfrom
magnesj:simplify-fishbones-trans-calc

Conversation

@magnesj
Copy link
Member

@magnesj magnesj commented Mar 20, 2026

Prepare for refactor of RicMswExportInfo

magnesj added 2 commits March 20, 2026 14:46
…appingTools test

Guard NNC cell indices against out-of-bounds in addNnc.
Fix test using ActiveCellIndex(1) on a single-element vector.
…unit tests

- Make findFishboneLateralsWellBoreParts public and return result by value
- Move WellBorePartForTransCalc to its own header RicWellBorePartForTransCalc.h
- Replace MSW tree traversal with direct RimFishbones lateral geometry iteration
- Add setSubsOrientationMode() to RimFishbones for deterministic test angles
- Add unit tests validating intersected cells and result values
@magnesj magnesj requested a review from jonjenssen March 20, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant