Handle empty matrix/vectors on multiply/add#847
Merged
kmokstad merged 2 commits intoOPM:masterfrom Mar 24, 2026
Merged
Conversation
add the result to the existing content can now handle that the target object is empty, considering it equivalent to being zero
Contributor
Author
|
jenkins build this with downstreams please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title applies to the second commit only. This will ensure the empty objects are automatically initialized when adding new values to them, instead of crashing.
The other commit is totally unrelated, only some BDF clean-up which was lying on my local branch.