-
Notifications
You must be signed in to change notification settings - Fork 8
feat(graph): enhance plotting support for polar coordinates #2 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): enhance plotting support for polar coordinates #2 #10
Conversation
|
Actually after a bit of thinking, this implementation is actually quite bad at recognising whether the user actually wants to plot a polar function or not. Say I type I would request you to implement the "starts with |
|
Yeah I just noticed that right now, you are absolutely right on that. I was just thinking of keeping functionalities same across cartesian and polar coords. |
|
Looks great. I'll review the code by this evening and merge it. Thanks! |
|
Really liked this PR. No obtrusive code changes, just the feature cleanly integrated into the pre-existing code. Thanks for contributing! |
|
Thank you !!! :) |
|
Please feel free to make any further feature requests or bug reports in this repo if you'd like |
|
Important @Tarun2605 It seems you haven't registered on the OPCODE Discord server (at https://discord.gg/F63kqjsJ). Please join it and register your GitHub account in the #register channel for your score to show up on the leaderboard |
|
I am sorry but what leaderboard are you talking about? |
|
Ohh didnt knew this was a competition. I just do open source for fun nowadays and to kill time. Sorry if I intervened. Thank you for taking my PR though. |
|
No problem lol, you can register on the Discord anyway. We have prizes for participants, and students from outside of IIIT Bhagalpur are also allowed to participate. Now don't tell me you're not a student 😅 |
|
Yeah yeah I am student. Final year at NSUT, Delhi. |

Description
This pull request enhances the plotting functionality in
src/core/Core/Application.cppby adding support for polar coordinate plots.Functions containing the variable
thetaare now automatically interpreted and plotted in polar form, expanding the application's graphing capabilities.ISSUE ADDRESSED: #2
Plotting Improvements
thetato identify polar equations and plot them using polar coordinates (r = f(theta)), converting results to(x, y)for rendering.thetavalues, drawing the corresponding polyline on the canvas.Codebase Updates
<cmath>header to support trigonometric operations required for polar plotting.These changes enable the application to visualize both standard and polar equations seamlessly.
Semver Changes
Issues
Checklist
ATTACHING OUTPUT SCREENSHOTS
CARTESIAN:

POLAR:
