This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Use nearest line rather than nearest point for bump chart mouseover#108
Open
jtrim-ons wants to merge 2 commits intoONSvisual:masterfrom
Open
Use nearest line rather than nearest point for bump chart mouseover#108jtrim-ons wants to merge 2 commits intoONSvisual:masterfrom
jtrim-ons wants to merge 2 commits intoONSvisual:masterfrom
Conversation
Contributor
Author
|
Should we do this for slope charts too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing version uses Voronoi polygons on the set of points for mouseover. This can mean that when you hover on a sloped line, it highlights another line instead.
The new version highlights the closest line to the mouse pointer, as measured by vertical distance.