Skip to content

Conversation

@kba
Copy link
Member

@kba kba commented Aug 22, 2020

Refactorings from #566:

  • ValidationReport is moved to ocrd_models
  • task_sequence and validate test cases decoupled (reduces redundant tests)

Refactoring from #559:

  • move helper methods (run_cli et al) from ocrd/processor/base.py to ocrd/processor/helpers.py

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2020

Codecov Report

Merging #573 into master will increase coverage by 0.04%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   84.15%   84.19%   +0.04%     
==========================================
  Files          48       49       +1     
  Lines        2752     2759       +7     
  Branches      538      538              
==========================================
+ Hits         2316     2323       +7     
  Misses        339      339              
  Partials       97       97              
Impacted Files Coverage Δ
ocrd_models/ocrd_models/report.py 100.00% <ø> (ø)
ocrd_validators/ocrd_validators/__init__.py 100.00% <ø> (ø)
ocrd/ocrd/processor/helpers.py 90.32% <90.32%> (ø)
ocrd/ocrd/processor/__init__.py 100.00% <100.00%> (ø)
ocrd/ocrd/processor/base.py 95.91% <100.00%> (+3.53%) ⬆️
ocrd_models/ocrd_models/__init__.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/json_validator.py 100.00% <100.00%> (ø)
...d_validators/ocrd_validators/ocrd_zip_validator.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/page_validator.py 77.19% <100.00%> (ø)
..._validators/ocrd_validators/workspace_validator.py 84.06% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3ffe4...a74d29d. Read the comment docs.

@kba kba marked this pull request as draft August 22, 2020 12:46
@kba kba changed the title Refactor ocrdwf Refactorings Aug 22, 2020
@kba kba marked this pull request as ready for review August 22, 2020 12:49
@kba kba merged commit 1a5d333 into master Aug 22, 2020
@kba kba deleted the refactor-ocrdwf branch August 22, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants