Skip to content

[17.0][REF] web_widget_product_label_section_and_note: Refactor the code to allow reusing the components#3486

Merged
OCA-git-bot merged 1 commit intoOCA:17.0from
Tecnativa:17.0-ref-web_widget_product_label_section_and_note
Mar 25, 2026
Merged

[17.0][REF] web_widget_product_label_section_and_note: Refactor the code to allow reusing the components#3486
OCA-git-bot merged 1 commit intoOCA:17.0from
Tecnativa:17.0-ref-web_widget_product_label_section_and_note

Conversation

@carlos-lopez-tecnativa
Copy link
Contributor

  • Use the component system to facilitate its use in other modules
  • Inherit the templates from Many2OneField instead of creating them from scratch

TT61582
@Tecnativa @pedrobaeza @CarlosRoca13 could you please review this?

… allow reusing the components

- Use the component system to facilitate its use in other modules
- Inherit the templates from Many2OneField instead of creating them from scratch
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested alongside the module sale_product_configurator_widget_product_label in a real instance.

@CarlosRoca13
Copy link
Contributor

please review ci

@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 25, 2026

The CI failure is fixed in OCA/oca-ci#123

@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3486-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 25, 2026
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-3486-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3486-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3473607 into OCA:17.0 Mar 25, 2026
3 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6bdeb1a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-ref-web_widget_product_label_section_and_note branch March 25, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants