[16.0] web_group_expand: show buttons in account ListView#3463
Open
robperezit wants to merge 1 commit intoOCA:16.0from
Open
[16.0] web_group_expand: show buttons in account ListView#3463robperezit wants to merge 1 commit intoOCA:16.0from
robperezit wants to merge 1 commit intoOCA:16.0from
Conversation
The account module defines a primary ListView buttons template (account.ListView.Buttons) used in invoices/bills lists (e.g. to add the Upload button). Since web_group_expand only extended web.ListView.Buttons, its expand/collapse buttons were not rendered in those views. Extend account.ListView.Buttons too, injecting the buttons in o_list_buttons when the list is grouped.
CRogos
reviewed
Mar 2, 2026
Contributor
CRogos
left a comment
There was a problem hiding this comment.
I think this would require a dependency on the account module?
I think a new module account_group_expand would be best.
Author
|
Thanks for the review! @CRogos To align with OCA conventions: would you prefer
I can adapt the PR accordingly (split into two PRs if needed). |
Contributor
|
You are asking the right questions... I don't know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account module defines a primary ListView buttons template (account.ListView.Buttons) used in invoices/bills lists (e.g. to add the Upload button). Since web_group_expand only extended web.ListView.Buttons, its expand/collapse buttons were not rendered in those views.
Extend account.ListView.Buttons too, injecting the buttons in o_list_buttons when the list is grouped.
#3123