Skip to content

Draft:[16.0][ADD] web_filter_header_button#3449

Open
KKamaa wants to merge 11 commits intoOCA:16.0from
Therp:16.0-web_filter_header_button
Open

Draft:[16.0][ADD] web_filter_header_button#3449
KKamaa wants to merge 11 commits intoOCA:16.0from
Therp:16.0-web_filter_header_button

Conversation

@KKamaa
Copy link

@KKamaa KKamaa commented Feb 24, 2026

A back port of v18.0 to v16.0

@KKamaa KKamaa force-pushed the 16.0-web_filter_header_button branch from 2a7c28e to 8be644e Compare February 24, 2026 06:05
@NL66278
Copy link
Contributor

NL66278 commented Feb 24, 2026

@KKamaa Please use the back-port method that preserves the commit history (same as we would do with forward migrations). As documented here (obviously replacing 15.0 with 18.0):
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch

chienandalu and others added 10 commits February 25, 2026 02:19
Now we can configure group filters to show up along the other filters so
users can easily access those as well.

TT49232
When there are too many buttons, they won't fit in the window and they
will overlap with other ui elemnets. We can prevent it putting them in
their own row.

TT49431
In custom views, like the reconciliation one, that use the control panel
we must prevent loading the FilterButton component.

TT49664
@KKamaa KKamaa force-pushed the 16.0-web_filter_header_button branch from 8be644e to 206be4a Compare February 24, 2026 23:31
@KKamaa
Copy link
Author

KKamaa commented Feb 24, 2026

@KKamaa Please use the back-port method that preserves the commit history (same as we would do with forward migrations). As documented here (obviously replacing 15.0 with 18.0): https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch

@NL66278 I preserved the commit history.

@KKamaa KKamaa force-pushed the 16.0-web_filter_header_button branch 2 times, most recently from e27edb5 to a4b009e Compare February 25, 2026 12:14
@NL66278
Copy link
Contributor

NL66278 commented Mar 13, 2026

@KKamaa It all works very well now. Can you please squash your three commits into one, and then this should be good to go.

@KKamaa KKamaa force-pushed the 16.0-web_filter_header_button branch from 4c2fcdc to b382f3d Compare March 14, 2026 11:47
@@ -1,10 +1,10 @@
# Copyright 2024 Tecnativa - David Vidal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove the existing Copyright, just add Therp on a separate line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yea, one should add the new copyright below the existing, sorry about that.

@KKamaa KKamaa force-pushed the 16.0-web_filter_header_button branch from b0e0329 to ec9d3a1 Compare March 16, 2026 13:25
@KKamaa KKamaa requested a review from NL66278 March 16, 2026 13:27
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278
Copy link
Contributor

NL66278 commented Mar 16, 2026

Pre-commit errros unrelated to this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants