[ADD] Implement delete method in BaseRestRequestsAdapter #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the delete method to the BaseRestRequestsAdapter class in the webservice module.
Problem:
Currently, the adapter has methods for get, post, and put, but it's missing an implementation for DELETE. This causes an AttributeError when trying to make a DELETE call via backend.call('delete', ...).
Solution:
A delete method has been added, following the same pattern as the other HTTP methods (get, post, put). It acts as a simple wrapper around the generic _request method, which already handles the underlying logic for making HTTP requests of any type.
With this change, DELETE requests can now be performed successfully using the webservice module.