Skip to content

[19.0][MIG] auto_backup: Migration to 19.0#3592

Open
BhaveshHeliconia wants to merge 55 commits intoOCA:19.0from
HeliconiaIO:19.0-mig-auto_backup
Open

[19.0][MIG] auto_backup: Migration to 19.0#3592
BhaveshHeliconia wants to merge 55 commits intoOCA:19.0from
HeliconiaIO:19.0-mig-auto_backup

Conversation

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

Proposed Changes

Migration

  • Replaced deprecated _sql_constraints with models.Constraint.
  • Standardized translations using self.env._.

Tests

  • Cleaned backup directories in TestDbBackup.setUp using shutil.rmtree.
  • Updated test_action_sftp_test_connection_success to check display_notification instead of UserError.
  • Made test_action_backup_local_cleanup independent and self-contained.

Code Quality

  • Added # pylint: disable=no-search-all in action_backup_all() (intentional full search).

Yenthe666 and others added 30 commits April 3, 2026 13:20
Added all the new fields and sentences. This will be the template for
translations.
Used to open  fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
- Follow template README.
- Remove HTML README.
- Move models to models folder.
- Model and view file names follow guidelines.
- Unused methods cleanup.
- Remove unneeded `.pot` file.
- Fix permissons.
- Follow PEP8 in names everywhere.
- Set more descriptive field names.
- Disable backups for other databases, for security.
- Remove db name from generated file, for easier cleanup.
- EAFP logic everywhere.
- More descriptive name.
- Data files moved to YAML, with cleaner ir.cron record creation.
- Add permissions for db.backup model.
- Icons.
- Update tests with new format.
- Storage method is a selectable, for easier extensibility.
- Instead of custom mailing, it just has a mail thread where you can subscribe.
- Should fix almost all comments in OCA#203.
- Reduce headers.

This respects the upstream license choice (GPL/AGPL) but reduces
verbosity.

It would be ideal to have everything under AGPL though.
* Add self.ensure_ones
* Add test coverage
* [10.0][auto_backup] Menu entry moved

* Update version in manifest
Currently translated at 58.2% (32 of 55 strings)

Translation: server-tools-11.0/server-tools-11.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/
Added test coverage
Added requirements.txt for pysftp
Added in the roadmap the exact version of pysftp for this to work (0.2.8)
Added in the roadmap the problem with list_db=False
Adapted calls to message_post
Currently translated at 17.5% (14 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/
Currently translated at 26.2% (21 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 51.2% (41 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/hr/
Currently translated at 80.2% (69 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 9.3% (8 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/ca/
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/es_AR/
Currently translated at 94.1% (81 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
badbole and others added 25 commits April 3, 2026 13:20
Currently translated at 50.0% (43 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/hr/
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
Currently translated at 90.0% (72 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 90.0% (72 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 84.7% (72 of 85 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 100.0% (85 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/es/
Currently translated at 87.0% (74 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/
Currently translated at 100.0% (73 of 73 strings)

Translation: server-tools-18.0/server-tools-18.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auto_backup/it/
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537

```
File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 9, in <module>
    import pysftp
  File "/home/odoo/.cache/pypoetry/virtualenvs/18-0-liVCuCj7-py3.12/lib/python3.12/site-packages/pysftp/__init__.py", line 14, in <module>
    from paramiko import AgentKey, RSAKey, DSSKey
ImportError: cannot import name 'DSSKey' from 'paramiko'
```

The import error was dropped silently, making the error show up as

```
File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 28, in <module>
    class TestConnectionException(pysftp.ConnectionException):
                                  ^^^^^^
NameError: name 'pysftp' is not defined
```
Currently translated at 63.5% (47 of 74 strings)

Translation: server-tools-18.0/server-tools-18.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auto_backup/sl/
Currently translated at 100.0% (74 of 74 strings)

Translation: server-tools-18.0/server-tools-18.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auto_backup/ru/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.