[19.0][FIX] Added missing security rules for two models#3581
Open
[19.0][FIX] Added missing security rules for two models#3581
Conversation
pedrobaeza
changed the title
pedrobaeza
reviewed
Mar 30, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Now that we are here, shouldn't these permissions be adjusted for the admin group only?
…hts to base.group_system
wpichler
force-pushed
the
19.0-fix-database_cleanup
branch
from
7db800e to
0f2ef4f
Compare
Author
|
i've changed it to base.group_system - force push... |
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Please check again, I don't see base.group_system in the access rules. Also, please mention the module name in the commit message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.