[16.0][IMP] database_cleanup: purge orphaned attachments

[Aldeigja]

Add wizard to list ir.attachment records whose store_fname points to a missing file on disk when storage is "file", and allow purging those rows.

[StefanRijnhart]

Thanks! Judging from the name of the PR and the patterns from this module, I would have expected signalling attachments where the model no longer exists or the res_id is not present as a record. This makes sense as well, but to make it explicit what the issue is with each attachment (and to prepare for extension with other possible error conditions), would you mind adding a reason field to the wizard line model as is done in cleanup.purge.line, with for now a fixed reason like 'File missing in filestore'?

[StefanRijnhart]

Thanks for the updates! Please squash commits.

[StefanRijnhart]

Thanks, the error message is stored correctly.

Usability wise, I think as a user I would want to see some more information about the attachments, the res_model, res_id and res_name, with or without optional visibility. Is this not something that you want for your own purposes?

[Aldeigja]

@StefanRijnhart

Usability wise, I think as a user I would want to see some more information about the attachments, the res_model, res_id and res_name, with or without optional visibility.
Is this not something that you want for your own purposes?

Our objective in creating this PR was to clean approximately 15,000 orphaned attachments simultaneously. We didn’t have to inspect every single attachment.
However, if users need to check details, they can do so by clicking on the line, opening the line pop-up, and then accessing the attachment form.

[StefanRijnhart]

OK, leaving my last comment as a nice to have. Nice work!