[18.0][FIX] impersonate_login access issues#913
Open
Conversation
florian-dacosta
approved these changes
Mar 26, 2026
Contributor
florian-dacosta
left a comment
florian-dacosta
left a comment
There was a problem hiding this comment.
Code review LGTM
It should fixes most of the errors linked to the issue. if we find more error of this type on not transient models, we can decide if we need to do something more then.
At least the hook gives the possibility to manage it with real user in your own project if you feel the need.
Thanks
Contributor
|
@sebastienbeau can you review please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue : #902
Add an inheritable function to keep real user on create / write on selected models. In this case, transient and abstract models.
cc @florian-dacosta