Skip to content

Conversation

@BT-vstoev
Copy link

@BT-vstoev BT-vstoev commented Oct 14, 2025

+ Functional change: Handling the "Test Connection button":

image
  • Inside the method a conf dict is constructed and then the _connect method is called directly with that dict.
  • Because of this hardcoded dict the "Test Connection" fails for the auth_ldaps module as we introduce new fields that should be part of the configuration for it.
  • I thought about some approaches on how to solve this:
    • full override of the test_ldap_connection method. This will work, but doesn't seem like a good practice.
    • use if conf.get("is_ssl") in the _connect method extension in auth_ldaps instead of the current if conf["is_ssl"]:. This will obviously make the button "work", but actually it will not be performing a proper test of an SSL connection.. so technically - not work :)
    • Add context to the button and based on the presence of this context enrich the configuration from the record - this is the approach I chose.

etobella and others added 30 commits October 14, 2025 10:27
Currently translated at 100.0% (6 of 6 strings)

Translation: server-auth-14.0/server-auth-14.0-auth_ldaps
Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: server-auth-14.0/server-auth-14.0-auth_ldaps
Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-15.0/server-auth-15.0-auth_ldaps
Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_ldaps/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.