[19.0][MIG] purchase_order_revision: Migration to 19.0#3004
Open
BhaveshHeliconia wants to merge 7 commits intoOCA:19.0from
Open
[19.0][MIG] purchase_order_revision: Migration to 19.0#3004BhaveshHeliconia wants to merge 7 commits intoOCA:19.0from
BhaveshHeliconia wants to merge 7 commits intoOCA:19.0from
Conversation
|
@BhaveshHeliconia Dependent module has been merged. You can remove the last commit. |
BhaveshHeliconia
force-pushed
the
19.0-mig-purchase_order_revision
branch
from
42ac82e to
7e0efec
Compare
Contributor
Author
Done. Thanks! |
OCA-git-bot
added
mod:purchase_order_revision
CRogos
suggested changes
Apr 20, 2026
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
- Could you have a look into the migration of sale_order_revision, that we also adapt to the current revision changes? OCA/sale-workflow#4024
- When you navigate to the prev. Revisions, I think we should get rid of the summary above the list?
BhaveshHeliconia
force-pushed
the
19.0-mig-purchase_order_revision
branch
from
7e0efec to
c11d398
Compare
|
The opened view looks good now, but the list is not filtered on the related purchases. 
|
|
Could you also squash these: |
BhaveshHeliconia
force-pushed
the
19.0-mig-purchase_order_revision
branch
from
c11d398 to
af6d8eb
Compare
CRogos
approved these changes
Apr 20, 2026
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
Strange that the verison 17+18 are not available, and the migration is done from 16.0.
Nevertheless module is working and code LGTM.
If there are two commits with add and update of the same person and the same language, these changes can be merged as well... but only a minor issue.
BhaveshHeliconia
force-pushed
the
19.0-mig-purchase_order_revision
branch
from
af6d8eb to
c6a85fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.