Skip to content

[16.0][ADD] purchase_planned_date_container_deposit: When date_planned is set manually, prevent calculation of the field up#2979

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
chaule97:16.0-fix-purchase_date_planned_manual
Apr 20, 2026
Merged

[16.0][ADD] purchase_planned_date_container_deposit: When date_planned is set manually, prevent calculation of the field up#2979
OCA-git-bot merged 1 commit intoOCA:16.0from
chaule97:16.0-fix-purchase_date_planned_manual

Conversation

@chaule97
Copy link
Copy Markdown

@chaule97 chaule97 commented Mar 3, 2026

reopen: #2342

@chaule97
Copy link
Copy Markdown
Author

@cyrilmanuel Do you want to merge?

@cyrilmanuel
Copy link
Copy Markdown
Contributor

hi @pedrobaeza this pr can be merge by you ?

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 16.0 milestone Mar 23, 2026
@pedrobaeza
Copy link
Copy Markdown
Member

Such long names may have problems in certain publication pipelines. Can you short it?

@cyrilmanuel
Copy link
Copy Markdown
Contributor

@chaule97 is it good for you to short that one ?

@chaule97 chaule97 force-pushed the 16.0-fix-purchase_date_planned_manual branch 3 times, most recently from 78ec8c1 to fd6ccd9 Compare March 23, 2026 13:41
@chaule97 chaule97 changed the title [16.0][ADD] purchase_date_planned_manual_container_deposit_product: When date_planned is set manually, prevent calculation of the field up [16.0][ADD] purchase_planned_date_container_deposit: When date_planned is set manually, prevent calculation of the field up Mar 23, 2026
@chaule97
Copy link
Copy Markdown
Author

Hello @cyrilmanuel , @pedrobaeza , is this name okay?

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2979-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 23, 2026
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2979-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@chaule97 chaule97 force-pushed the 16.0-fix-purchase_date_planned_manual branch from fd6ccd9 to 34f1096 Compare March 24, 2026 02:44
@chaule97
Copy link
Copy Markdown
Author

Hello @cyrilmanuel , about chrome test bug, what should I do ?

2026-03-24 02:50:43,338 626 ERROR odoo odoo.addons.purchase_sign.tests.test_purchase_sign: ERROR: TestPurchaseSign.test_01_portal_purchase_signature_tour
Traceback (most recent call last):
  File "/__w/purchase-workflow/purchase-workflow/purchase_sign/tests/test_purchase_sign.py", line 45, in test_01_portal_purchase_signature_tour
    self.start_tour("/", "purchase_signature", login="portal")
  File "/opt/odoo/odoo/tests/common.py", line 2078, in start_tour
    return self.browser_js(url_path=url_path, code=code, ready=ready, **kwargs)
  File "/opt/odoo/odoo/tests/common.py", line 2049, in browser_js
    self.browser._wait_code_ok(code, timeout, error_checker=error_checker)
  File "/opt/odoo/odoo/tests/common.py", line 1597, in _wait_code_ok
    pathlib.Path(self.user_data_dir, "chrome_debug.log").read_bytes(),
  File "/usr/lib/python3.10/pathlib.py", line 1126, in read_bytes
    with self.open(mode='rb') as f:
  File "/usr/lib/python3.10/pathlib.py", line 1119, in open
    return self._accessor.open(self, mode, buffering, encoding, errors,
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpc7lv62v9_chrome_odoo/chrome_debug.log'

@cyrilmanuel
Copy link
Copy Markdown
Contributor

cyrilmanuel commented Mar 26, 2026

hi @chaule97 same error as you on another pr, OCA/sale-workflow#4195

seems to be fixed now if we rebase the code :)

@chaule97 chaule97 force-pushed the 16.0-fix-purchase_date_planned_manual branch from 34f1096 to 84f09f9 Compare March 26, 2026 07:10
@chaule97
Copy link
Copy Markdown
Author

Hola @pedrobaeza , could you please merge again?

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2979-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 26, 2026
Signed-off-by pedrobaeza
@chaule97
Copy link
Copy Markdown
Author

@cyrilmanuel wow we have another problem :)

@cyrilmanuel
Copy link
Copy Markdown
Contributor

mmmm not sure if it's something wrong on the merge or if the manifest contain an error. @pedrobaeza do you have an idea ?

@pedrobaeza
Copy link
Copy Markdown
Member

I don't have idea I'm afraid. Have you do a pre-commit run to make sure everything related to setup is OK?

@chaule97 chaule97 force-pushed the 16.0-fix-purchase_date_planned_manual branch from 84f09f9 to 27471e0 Compare March 31, 2026 03:49
@chaule97
Copy link
Copy Markdown
Author

Hi @pedrobaeza , Can we try again?

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2979-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 31, 2026
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@pedrobaeza The merge process could not be finalized, because command /tmp/tmpp0oh5us7/bin/python -P -m build --wheel --outdir /tmp/tmp8408apw5 --no-isolation /tmp/tmpag0ok9s4/purchase_planned_date_container_deposit/../setup/purchase_planned_date_container_deposit failed with output:

* Getting build dependencies for wheel...
* Building wheel...
error in setup command: /tmp/tmpag0ok9s4/setup/purchase_planned_date_container_deposit/odoo/addons must contain exactly one installable Odoo addon dir, found []

ERROR Backend subprocess exited when trying to invoke build_wheel

@HviorForgeFlow
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2979-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 31, 2026
Signed-off-by HviorForgeFlow
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@HviorForgeFlow The merge process could not be finalized, because command /tmp/tmpp0oh5us7/bin/python -P -m build --wheel --outdir /tmp/tmp6tkdn9hc --no-isolation /tmp/tmp3oixgu4a/purchase_planned_date_container_deposit/../setup/purchase_planned_date_container_deposit failed with output:

* Getting build dependencies for wheel...
* Building wheel...
error in setup command: /tmp/tmp3oixgu4a/setup/purchase_planned_date_container_deposit/odoo/addons must contain exactly one installable Odoo addon dir, found []

ERROR Backend subprocess exited when trying to invoke build_wheel

@cyrilmanuel
Copy link
Copy Markdown
Contributor

hi @chaule97 it seem's that the setup folder are wrong. perhaps because it dosen't contain the module. do you know how to generate that one ? ( i didn't create a module and create the setup part. i cannot help you on that)
@pedrobaeza or @HviorForgeFlow do you know how it work from the setup and what shall be present on the pr ?

that seems to be wrongly generated on setup (normally we found a copy of the module)

…et manually, prevent calculation of the field upon PO confirmation
@chaule97 chaule97 force-pushed the 16.0-fix-purchase_date_planned_manual branch from 27471e0 to e75b958 Compare April 20, 2026 07:30
@OCA-git-bot OCA-git-bot added series:16.0 mod:purchase_planned_date_container_deposit Module purchase_planned_date_container_deposit labels Apr 20, 2026
@chaule97
Copy link
Copy Markdown
Author

Hi @pedrobaeza , Can we try again?

@pedrobaeza
Copy link
Copy Markdown
Member

pre-commit should auto-fix it.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2979-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0b6d08a into OCA:16.0 Apr 20, 2026
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 44665d7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants