[19.0][MIG] mis_builder: Migration to 19.0 #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qlasta
force-pushed
the
19.0-mig-mis_builder
branch
2 times, most recently
from
978940b to
030175e
Compare
Qlasta
commented
Nov 25, 2025
| account_ids.update(self._account_ids_by_acc_domain[acc_domain]) | ||
| if not account_id: | ||
| aml_domain.append(("account_id", "in", tuple(account_ids))) | ||
| aml_domain.append(("account_id", "in", list(account_ids))) |
Author
There was a problem hiding this comment.
tuple here replaced to list, because later used Domain normalizes values to lists anyway. Later tests are also adapted.
Member
|
Hi! Thanks for working on this. I have merged the latest 18.0 changes on 19.0. Can you rebase to get a smaller diff? |
Qlasta
force-pushed
the
19.0-mig-mis_builder
branch
from
030175e to
5a10462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.