[18.0][REF][ADD] mis_builder_report_xlsx #728

legalsylvain · 2025-09-19T22:11:28Z

depends on [V18/V19] splitting module in many more little modules #726

Creation of `mis_builder_report_xlsx`

Extract "xlsx" feature from mis_builder, creating mis_builder_report_xlsx
migration scripts :
- rename mis_builder.xls_export to mis_builder_report_xlsx.xls_export
- install new module mis_builder_report_xlsx
Create Readme section in the new module

cloc of mis_builder

Before :

Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          40            699            935           5667
XML                              9              2              6           1169
JavaScript                       1             24             15            164

After :

Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          39            675            918           5395  (-5%)
XML                              8              2              6           1136  (-3%)
JavaScript                       1             23             15            155  (-5%)

Description

This module improves the MIS Reports modules, allowing to download MIS Reports in XLSX format.

Usage

Go to MIS Reports list and form views.
Click on 'Export' Button to download your XLSX file.

In the same way, a button is present in the 'preview' form view of your MIS reports.

@sbidoul : what do you think ?

Regards.

OCA-git-bot · 2025-09-19T22:11:33Z

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

sbidoul

Thanks for this, Sylvain. I'm fine with extracting that part if you think it's useful.

It looks good to me overall. I have not verified all the code was moved correctly but I found one suspicious thing. See the comments.

sbidoul · 2025-09-20T12:22:25Z

mis_builder/migrations/18.0.2.0.0/pre-migration.py

+
+xmlid_renames = [
+    ("mis_builder.xls_export", "mis_builder_report_xlsx.xls_export"),
+]


Is this not done automatically?

if the original database is :

id | name | type -----+---------------------------------------------+------------------- 288 | {"en_US": "MIS report instance XLS report"} | ir.actions.report

With that script:

during update

2025-09-25 09:25:36,222 71906 DEBUG mis_builder_v1 OpenUpgrade: 1 rows affected after 0:00:00.000510 running UPDATE ir_model_data SET module = 'mis_builder_report_xlsx', name = 'xls_export' WHERE module = 'mis_builder' and name = 'xls_export'

in database, after the update

id | name | type -----+---------------------------------------------+------------------- 288 | {"en_US": "MIS report instance XLS report"} | ir.actions.report

Without that script

during update

2025-09-25 09:30:18,601 72300 INFO mis_builder_v2 odoo.addons.base.models.ir_model: Deleting 288@ir.actions.report (mis_builder.xls_export)

in database, after the update

id | name | type -----+---------------------------------------------+------------------- 289 | {"en_US": "MIS report instance XLS report"} | ir.actions.report

So it can be usefull if this action was referenced in some action_id field.
(It's maybe quite theoritical, but it's an OpenUpgrade good practice)

mis_builder_report_xlsx/__manifest__.py

sbidoul · 2025-09-20T12:23:53Z

mis_builder_report_xlsx/models/mis_report_instance.py

+SRC_ACTUALS = "actuals"
+SRC_ACTUALS_ALT = "actuals_alt"
+SRC_CMPCOL = "cmpcol"
+SRC_SUMCOL = "sumcol"
+
+MODE_NONE = "none"
+MODE_FIX = "fix"
+MODE_REL = "relative"


Why are these constants here?

Good catch. Totally useless. Removed.

sbidoul · 2025-09-20T12:26:17Z

mis_builder_report_xlsx/__manifest__.py

+    " that allow to export MIS report in XSLX format.",
+    "version": "18.0.1.0.0",
+    "license": "AGPL-3",
+    "author": "ACSONE SA/NV, GRAP, Odoo Community Association (OCA)",


Do feel it's important to add GRAP as author here. In a way it is not "new" as it is shuffling code around.

Sorry, I don't understand. Do you want me to remove GRAP, or not?

Personally, I usually add my company name when I spend a significant amount of time on a module. (development, refactoring, etc.)
But it's a matter of taste, so tell me what to do!

pedrobaeza

I think this should be done in 19, not in this version.

legalsylvain · 2025-09-20T14:10:44Z

I think this should be done in 19, not in this version.

Hi @pedrobaeza. Thanks for your answer ! In fact, this PR is, for the time being, just a PoC I did regarding the proposal present in #726.
As said in #726,

As a result, my question here is ONLY "in an ideal world, Do you think it's better to split modules, or to keep a single big one ?".
Once this first question answered, and if refactor is desired by PSC, we could focus on the next question : "on which version we are applying this refactor ? (current V18 version, or new V19 release).

Could you so give your PoV on the other main issue ?
thanks !

pedrobaeza · 2025-09-20T14:15:54Z

Although the excel export requires the extra dependency, we already have it also on account_financial_report, so for me it's not critical to split it, and I will always install both.

legalsylvain · 2025-09-20T19:46:49Z

Although the excel export requires the extra dependency, we already have it also on account_financial_report, so for me it's not critical to split it, and I will always install both.

Hi. I didn't make myself clear. I wanted you to comment on the other issue #726.

thanks.

sbidoul · 2025-10-27T18:08:27Z

Thinking about this again I now have some doubts.

For instance, when the annotations feature was added it was added on the html, pdf and xlsx formats at once.
If the xlsx export had been in a separate module maybe the contributor could have argued that it was not necessary to implement it the Excel export and that would have been left with a PR doing only a part of the work.

That is very hypothetical of course, but I worry a bit that the different parts would then evolve at a different speed and therefore lead to a less cohesive result.

legalsylvain · 2025-10-27T22:11:24Z

Hi @sbidoul. Well, I think that each design has its limitations.

Having a single module is harder to port, requires more dependencies, force users to install potentially non desired features.
With many modules, some users could ignore some features, because the features are present in an non installed module. Also it allows to have features not fully implemented, as you describe.
To overcome this last concern, we can force contributors to implement each features in pdf / html / xlsx format. (whatever if there is one or more modules, it can be a prerequite to contribute).

Finally, It's up to you ! You are the chief architect of this repository !

Please let me know your decision.

…module Co-authored-by: Stéphane Bidoul <stephane.bidoul@acsone.eu>

legalsylvain · 2025-11-21T10:01:22Z

Hi @sbidoul. could you finalize your review here :

merge this PR, if you agree.
close this PR, if you disagree.

Migration to V19 begin to be done. This work is starting to get moldy ;-)

Thanks !

sbidoul · 2025-11-22T11:46:28Z

I'm going to close this, as I think XLSX export is an integral part of the core MIS Builder app.

Thanks for your patience and sorry for the hesitation.

legalsylvain · 2025-11-23T21:46:34Z

Thanks for your answer, @sbidoul.

Regarding my last PR on mis-builder, could you take a time to answer to that question when you have time ? thanks ! #732 (comment)

legalsylvain force-pushed the 18.0-REF-ADD-mis_builder_report_xlsx branch 3 times, most recently from a320ff0 to c6823a6 Compare September 19, 2025 22:56

sbidoul reviewed Sep 20, 2025

View reviewed changes

pedrobaeza reviewed Sep 20, 2025

View reviewed changes

legalsylvain force-pushed the 18.0-REF-ADD-mis_builder_report_xlsx branch 3 times, most recently from e4fdc2d to a6330c6 Compare September 25, 2025 09:51

legalsylvain marked this pull request as ready for review September 25, 2025 09:53

legalsylvain mentioned this pull request Sep 25, 2025

[V18/V19] splitting module in many more little modules #726

Open

legalsylvain force-pushed the 18.0-REF-ADD-mis_builder_report_xlsx branch from a6330c6 to 4bf9e8e Compare October 27, 2025 20:13

[REF] split mis_builder into mis_builder and mis_builder_report_xlsx …

e286a33

…module Co-authored-by: Stéphane Bidoul <stephane.bidoul@acsone.eu>

legalsylvain force-pushed the 18.0-REF-ADD-mis_builder_report_xlsx branch from 4bf9e8e to e286a33 Compare November 12, 2025 21:01

sbidoul closed this Nov 22, 2025

Uh oh!

[18.0][REF][ADD] mis_builder_report_xlsx #728

[18.0][REF][ADD] mis_builder_report_xlsx #728

Uh oh!

Conversation

legalsylvain commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Creation of mis_builder_report_xlsx

cloc of mis_builder

Description

Usage

Uh oh!

OCA-git-bot commented Sep 19, 2025

Uh oh!

sbidoul left a comment

Choose a reason for hiding this comment

Uh oh!

sbidoul Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

legalsylvain Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbidoul Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

legalsylvain Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

sbidoul Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

legalsylvain Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

legalsylvain commented Sep 20, 2025

Uh oh!

pedrobaeza commented Sep 20, 2025

Uh oh!

legalsylvain commented Sep 20, 2025

Uh oh!

sbidoul commented Oct 27, 2025

Uh oh!

legalsylvain commented Oct 27, 2025

Uh oh!

legalsylvain commented Nov 21, 2025

Uh oh!

sbidoul commented Nov 22, 2025

Uh oh!

legalsylvain commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

legalsylvain commented Sep 19, 2025 •

edited

Loading

Creation of `mis_builder_report_xlsx`

legalsylvain Sep 25, 2025 •

edited

Loading