[FIX] Added missing .sudo or compute_sudo=True#441
Open
Conversation
This PR adds `_compute_sudo=True` to compute methods that access system models like (ir.model, ir.model.fields, ...) to avoid unexpected access errors in user interface. Also, this PR adds `.sudo()` when code accesses (reads) system models for same reasone.
Contributor
Author
|
@cormaza @legalsylvain @yvaucher @zamberjo Please, review this fix. Thanks a lot! |
Contributor
|
Hi. Could yiu explain the bug you want to solve ? (With step to reproduce) |
Member
|
I agree with @legalsylvain . We have been using this functionality for a long time without needing these privilege escalations. We need steps to reproduce the issue and a test case to verify it. |
Member
|
Seems dubious to me to add some random |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
_compute_sudo=Trueto compute methods that access system models like (ir.model, ir.model.fields, ...) to avoid unexpected access errors in user interface.Also, this PR adds
.sudo()when code accesses (reads) system models for same reasone.