[16.0][ADD] sale_dms_field #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@agent-z28 Can you please review this |
bizzappdev
force-pushed
the
16.0-sale_dms_field-BAD
branch
from
4cbc123 to
2eb302e
Compare
victoralmau
suggested changes
Sep 16, 2025
Comment on lines
1
to
7
| from odoo.addons.base.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestSaleDmsField(TransactionCase): | ||
| def setUp(self): | ||
| """Inherited method to create records. #Issue-249""" | ||
| super(TestSaleDmsField, self).setUp() |
Member
There was a problem hiding this comment.
Suggested change
| from odoo.addons.base.tests.common import TransactionCase | |
| class TestSaleDmsField(TransactionCase): | |
| def setUp(self): | |
| """Inherited method to create records. #Issue-249""" | |
| super(TestSaleDmsField, self).setUp() | |
| from odoo.addons.base.tests.common import BaseCommon | |
| class TestSaleDmsField(BaseCommon): | |
| @classmethod | |
| def setUpClass(cls): | |
| super().setUpClass() |
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
| <!-- Created a DMS access group for sale. #Issue-249 --> | |||
Member
There was a problem hiding this comment.
Suggested change
| <!-- Created a DMS access group for sale. #Issue-249 --> | |
| <!-- Created a DMS access group for sale. --> |
Everything related to “#Issue-249” should be removed, as it adds nothing to the code.
bizzappdev
force-pushed
the
16.0-sale_dms_field-BAD
branch
from
2eb302e to
b9aec6e
Compare
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 12e4672. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #375