Lookup compiler-generated objects dynamically #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm fixing a couple bugs with this PR, I'll request a review when it is ready |
Contributor
Author
|
Okay I think it is ready for review |
Contributor
Author
|
OK that was unintentional, lemme remake the PR |
Contributor
Author
|
@js6pak mentioned we may want to avoid dynamic invokes and use a delegate or something. I'll look into that when I'm free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactor currently patches a few state machines generated by the C# compiler. This is generally okay but with updates to the game, the names of the compiler generated classes can change. Additionally, these names are not consistent across platforms.
By dynamically resolving these objects at runtime, Reactor will be more resilient to game updates and platform differences, allowing for a single build to be used across multiple platforms.
This PR adds two new utility classes:
CompilerGeneratedObjectWrapper: This class provides a wrapper around a compiler generated object. It provides two functions, GetField and SetField, to get and set fields on objects via reflection.StateMachineWrapper<T>: This class inherits fromCompilerGeneratedObjectWrapperto add state machine specific utilities.These classes can be used by other mods that depend on Reactor as well.