Fix vulnerability icon for multi-project solution PM UI#7442
Open
zivkan wants to merge 1 commit into
Open
Conversation
jeffkl
approved these changes
Jun 2, 2026
Nigusu-Allehu
approved these changes
Jun 2, 2026
nkolev92
approved these changes
Jun 2, 2026
martinrrm
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14024
Fixes: NuGet/Home#14926
Description
In the solution-level PM UI Installed tab, when multiple projects reference different vulnerable versions of the same package, only the first project's version gets the vulnerability warning icon. The other projects' versions are missing the icon.
The root cause is in
PackageItemViewModel.UpdateVulnerabilityInfo(), which always usedVersion(the model's version) as the key when adding to theVulnerableVersionsdictionary. WhenUpdateInstalledPackagesVulnerabilitiesqueried vulnerability data for a different installed version, the result was stored under the model version instead of the queried version. This meantVulnerableVersions.TryGetValue()inPackageSolutionDetailControlModel.UpdateInstalledVersionsAsync()only succeeded for the model version.The fix adds a
NuGetVersion versionparameter toUpdateVulnerabilityInfoso each call site passes the correct version:Versionfor the model's own data, andpackageIdentity.Versionfor queried installed versions.Regression introduced by PR #6370.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A