Account for dual compatibility in AssetTargetFallback calculation - fix LockFileBuilderCache conflicts#7433
Merged
Merged
Conversation
jeffkl
approved these changes
Jun 2, 2026
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13326
Description
During solution restore, all projects share a
LockFileBuilderCache. The selection criteria cache (_criteriaSets) is keyed byCriteriaKey, which comparesAssetTargetFallbackFrameworkinstances usingEquals/GetHashCode.The problem:
AssetTargetFallbackFramework.Equals/GetHashCodeonly compared base framework properties and the fallback list. It did not account for theRootFrameworkbeing aDualCompatibilityFramework(used by C++/CLI projects to addnativeas a secondary framework).This meant
ATF(DCF(net6.0-windows7.0, native), [net461])andATF(net6.0-windows7.0, [net461])hashed and compared as equal. When the managed project restored first, its criteria (withoutnative) got cached, and the C++/CLI project reused those wrong criteria — sobuild/native/targets were never matched.Fix: Include
DualCompatibilityFramework's secondary framework inAssetTargetFallbackFramework.GetHashCode()andEquals(), so the two produce distinct cache keys.PR Checklist